Open
Conversation
…*qseqid_df[self.annotations.keys()].sum().to_dict() to fix indexing issue
…igned set of primers that this run will extend.
… and validate them against the given design file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @JasonAHendry. Following our discussion I had a go at adding this 'extend' functionality to multiply - hope you don't mind!
I'm not sure if this is how you would want to do it, but the way this change works is to add a new optional
[Extend]section to the design.inifile. To get this, you pass it a previously designed multiply output file, and it merges the primers with those from thegeneratestep for all the downstream stuff.Warning: it's not very thoroughly tested, though I tried a couple of designs. It does seem to work but of course there's a possibility I've missed something about the logic of the code.
The changes are:
parsing.py: make this understand the [Extend] section. You have to give it a
design_file, and also a list oftarget_ids(which must be a subset of those in the design file). And also optionallytarget_nameswhich , if you give them, must also match those in the design file. (Otherwise it gets the names from the design file.)generate/main.py: if the[Extend]section is given, add the previously-designed primers to the table before saving the candidate primer list.annotator.py: Note I also seemed to have to change one line of this to use a list rather than a dict as a data frame key, to get multiply to run. Please check this as I wasn't quite sure - could be a dependency version thing.I couldn't resist so also updated the pipeline image and the
README.mdFYI.What do you think? Please feel free to merge or let me know if you want any changes (or don't want this at all.)
Cheers,
g.