-
Notifications
You must be signed in to change notification settings - Fork 4
로그인 kakao oauth #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
로그인 kakao oauth #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏 |
dlwl98
approved these changes
Nov 8, 2023
Comment on lines
+72
to
+78
| const { refreshToken } = JSON.parse(loginInfo); | ||
|
|
||
| if (!refreshToken) { | ||
| setIsLogin(false); | ||
| } else { | ||
| setIsLogin(true); | ||
| } |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 refreshToken으로 검증하는 이유가 있나요?
1eecan
pushed a commit
that referenced
this pull request
Nov 9, 2023
* feat: 토글 버튼 없음 로직 추가 * feat: kakao oauth 구현 * feat: 정보입력 api 연동 * feat: 헤더에 로그인 버튼 추가 * fix: 가입 성공 시 토큰 저장 * fix: 카카오 리다이렉트
dlwl98
added a commit
that referenced
this pull request
Nov 13, 2023
* feat: 크루 리스트 api 호출 함수 및 메인페이지용 쿼리작성 * 크루 타입 일부 수정 * feat: 메인페이지 크루 api 부착 * 로그인 kakao oauth (#144) * feat: 토글 버튼 없음 로직 추가 * feat: kakao oauth 구현 * feat: 정보입력 api 연동 * feat: 헤더에 로그인 버튼 추가 * fix: 가입 성공 시 토큰 저장 * fix: 카카오 리다이렉트 * axiosInstance baseUrl 변경 (#158) * chore: axios baseURL 변경 - axiosInstance.ts 변경 - vite config proxy 변경 * fix: GamesHostPage 리뷰남기기 버튼 클릭핸들러 변경 * chore: vitest config proxy 변경 * fix: post patch api 함수 수정 - payload 잘 안담기던 것 수정 * fix: formatDate 함수 수정 * fix: AllServicePage 로컬스토리지 키 변경 * feat: 메인페이지 근처경기목록 apu 호출 함수 인자 변경 * chore: 불필요한 console.log 제거 --------- Co-authored-by: 1g2g <87280835+1g2g@users.noreply.github.com> Co-authored-by: 이진욱 <ff981113@hanyang.ac.kr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
카카오 oauth 로그인을 구현했습니다.
👨💻 구현 내용 or 👍 해결 내용
feat: 토글 버튼 없음 로직 추가
feat: kakao oauth 구현
feat: 정보입력 api 연동
feat: 헤더에 로그인 버튼 추가
🎯 PR 포인트
📝 참고 사항
백엔드랑 연동 잘 되는지 확인 해봐야 할 것 같습니다!
❓ 궁금한 점