Maintenance #19
Merged
Maintenance #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing support for other dialects
Contributor
TimothyGillespie
left a comment
TimothyGillespie
left a comment
There was a problem hiding this comment.
As it is only a draft I only gave it a cursory look. When it is ready for review, please mark request me for review, since I'm not sure if I will beinformed about any status change.
…Stack/ORM into TimothyGillespie/addOrderByTests
…ent it in the query builder as i'm way too tired (:
|
|
||
| private static void validateName(String name) { | ||
| if(!NAME_PATTERN.matcher(name).matches()) | ||
| throw new ORMQueryException("Invalid column name '" + name + "' (Use raw in case you know what you're doing)"); |
Contributor
There was a problem hiding this comment.
This solves the other aspect of the issue of #14. If this branch is merged the issue can be closed.
Contributor
|
I will review this tomorrow or later this evening. |
Contributor
TimothyGillespie
left a comment
TimothyGillespie
left a comment
There was a problem hiding this comment.
See no issue with this merge request when #26 is merged or otherwise addressed.
This reverts commit 335f633.
Contributor
|
I changed #26 as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is supposed to redesign the query building process to allow implenting other dialects aswell as fixing issues that came up in the last months.