Clean up CI: scoped coverage, bump coveralls and php-cs-fixer#606
Merged
Conversation
- test.yml: only install xdebug and upload coverage on the PHP 8.3 job; every other matrix entry runs with `coverage: none`. Cuts wall time significantly without changing what we actually report. - test.yml: bump php-coveralls/php-coveralls from ^1.0 (2018) to ^2.7. - php-cs-fixer.yml: bump actions/checkout to v4 (aligned with test.yml) and oskarstark/php-cs-fixer-ga from 2.18.6 to 3.26.0. - Rename .php_cs.dist to the v3-canonical .php-cs-fixer.dist.php and update the config to v3 syntax (`new PhpCsFixer\Config()`, rule renames). Drops the explicit --config flag since the new filename is auto-discovered. - .gitignore: rename .php_cs.cache to .php-cs-fixer.cache to match v3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
php-coveralls/php-coveralls v2 renamed its bin from `coveralls` to `php-coveralls`, so the previous invocation died with `coveralls: command not found` on the PHP 8.3 coverage job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI hygiene with no impact on detection behaviour:
--coverage-clover. Everything else runs withcoverage: none, which is meaningfully faster.^1.0is from 2018. Bumped to^2.7.2.18.6(unmaintained) to3.26.0. Required the config rewrite below..php_cs.dist→.php-cs-fixer.dist.php(v3 canonical name, so the--configflag is no longer needed), switchedConfig::create()tonew Config(), and renamed the two rules that v3 changed (sortAlgorithm→sort_algorithm,trailing_comma_in_multiline_array→trailing_comma_in_multiline).actions/checkout@v3→@v4in the cs-fixer workflow (aligns withtest.yml);.gitignoreupdated to match v3's cache filename.Test plan
vendor/bin/phpunitstill green (19 tests, 2,274,786 assertions)php -l .php-cs-fixer.dist.phpclean🤖 Generated with Claude Code