You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 11, 2021. It is now read-only.
Everything looks perfect. After this pull request please send your pull request from VisualStates and VisualStates-examples repos so that I can easily push small changes.
On my computer (maybe because of the bad rendering of intel graphics card), the shadows makes the scene so dark. Also, please make sure that the camera pose of the world files are set such that when a user runs the scene, they can see the whole action without repositionning the camera. To achieve these, can you replace your world file with the following version:
Thanks for the review :D I made the suggested changes in the recent commit.
The changes in the prius plugin and the sdf was to add support for multiple instances of prius in a gazebo world. The previous implementation didn't allow spawning of multiple prius cars, so I added a namespace to each individual car solving the issue. There would be conflicts with the previous example, but yes we'll resolve them with further development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo of following example - https://www.youtube.com/watch?v=lBrgfQM1-X0