Skip to content
This repository was archived by the owner on Feb 21, 2021. It is now read-only.

Solved issue #702 with image#719

Closed
Diegojnb wants to merge 0 commit into
JdeRobot:masterfrom
Diegojnb:uav_viewer
Closed

Solved issue #702 with image#719
Diegojnb wants to merge 0 commit into
JdeRobot:masterfrom
Diegojnb:uav_viewer

Conversation

@Diegojnb
Copy link
Copy Markdown
Contributor

Left joystick for yaw and elevation.

Right joystick x and y axis

uav_viewer

@fqez
Copy link
Copy Markdown
Member

fqez commented Mar 13, 2017

Hi Diego!

nice work, it looks really cool. Unfortunately we cannot merge this changes because of the following reasons:

  • The CMakeLists.txt file is deprecated in your PR, you should have started coding this enhancement from an updated version of the uav_viewer_py tool.
  • The cameraFilter file is not needed in this tool. I think you inherited this class from the follow_turtlebot example.
  • The file ui_gui.ui is deleted in your PR, however this file is needed by the tool to generate the GUI.
  • Also, there is some code related with MyAlgorithm class, which must not be here. The code for MyAlgorithm.py is only included in the TeachingRobotics repository.

The rest of the code seems to be good, so no problem with that. I recommend you to update the JdeRobot repo from github and add your chages over that version of uav_viewer_py instead. I you need help with that, tell us and we will help you gladly :D

Good job anyway!

@fqez fqez closed this Mar 13, 2017
@fqez fqez reopened this Mar 13, 2017
@Diegojnb Diegojnb closed this Mar 13, 2017
aitormf added a commit that referenced this pull request Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants