Skip to content
This repository was archived by the owner on Feb 21, 2021. It is now read-only.

[issue #747] Prepared color Tuner py to be launched like a binary#748

Merged
fqez merged 2 commits into
JdeRobot:masterfrom
aitormf:tools/colortuner/bin
Apr 6, 2017
Merged

[issue #747] Prepared color Tuner py to be launched like a binary#748
fqez merged 2 commits into
JdeRobot:masterfrom
aitormf:tools/colortuner/bin

Conversation

@aitormf
Copy link
Copy Markdown
Collaborator

@aitormf aitormf commented Apr 4, 2017

Now ColorTuner py can be launched like a binary tool:

colorTuner colorTuner_py.cfg

fix #747

@fqez fqez merged commit 5980439 into JdeRobot:master Apr 6, 2017
@shivangg
Copy link
Copy Markdown
Contributor

Shouldn't this be named colorTuner_py:

  1. To avoid the confusion with the C++ version of colorTuner
  2. The component's is actual name is colorTuner_py.

@jmplaza
Copy link
Copy Markdown
Member

jmplaza commented Apr 17, 2017

Hi @shivangg,

the C++ ColorTuner version is deprecated and has been removed from the official repo, in order to avoid having too flavors of the same tool and the possible confusion you mention.

In the current src/tools directory, the directory for this tool is named colorTuner_py, just as a convention to indicate that it is coded in Python, but the component itself is named colorTuner.py and launched simply as colorTuner

Hope it helps

@aitormf aitormf deleted the tools/colortuner/bin branch April 21, 2017 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add script to lauch colorTuner_py like a binary

4 participants