This repository was archived by the owner on Feb 21, 2021. It is now read-only.
[Issue #792] Fix compilation warnings - some warnings addressed#886
Merged
Conversation
Collaborator
|
all works for me |
Member
|
Nice job @lr-morales are you planning on keep adressing warnings? Or should we merge this already? Cheers! |
Member
Author
|
I have located some more "easy-to-solve" warnings, we can wait them before merging. I can comment again when I finish or feel that solving more warnings would take long in order to merge the ones already cleared and checked. |
lr-morales
force-pushed
the
global/build/792-fix-warnings
branch
from
f066d4f to
2be59b8
Compare
Member
Author
Collaborator
|
It's all Ok for me, good job @lr-morales |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should address some of the compilation warnings produced when building JdeRobot, mostly non-return (as best as could without changing function return type) and unsigned comparison warnings.