Skip to content
This repository was archived by the owner on Feb 21, 2021. It is now read-only.

[issue #739] YoutubeServer#950

Merged
fqez merged 2 commits into
JdeRobot:masterfrom
apavo:master
Dec 19, 2017
Merged

[issue #739] YoutubeServer#950
fqez merged 2 commits into
JdeRobot:masterfrom
apavo:master

Conversation

@apavo
Copy link
Copy Markdown

@apavo apavo commented Nov 12, 2017

[issue #739] YouTubeServer: getting images from YouTube web page

@fqez
Copy link
Copy Markdown
Member

fqez commented Nov 13, 2017

Hi @apavo nice job!

I only miss one file: the CMakeLists.txt file. This file must install your server along the rest of the components of JdeRobot. So when you add that file I can merge this PR (after testing it, of course).
If you don't know how to write that file, you can see another jderobot driver's CMakeLists.txt file, for instance: MAVLinkServer's CMakeLists

cheers!

@fqez
Copy link
Copy Markdown
Member

fqez commented Nov 20, 2017

Also, can you record a video or write down a little 'how to' in order to give us a reference for executing and testing your new server? That would be so useful!

thanks!!

@fqez fqez merged commit 5ebcb93 into JdeRobot:master Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants