Need tests for: menu does not open on click if `searchable` is `true`

[jochenberger]

Follow-up for 2746261#diff-04191649796841200b33375bdff7c78fR231

[JedWatson]

Thanks @jochenberger

[jochenberger]

git bisect blames #1902 / f7cd6c2

[jochenberger]

Or rather #1580.

[jochenberger]

Maybe the default value for openAfterFocus should be true.
I wonder why the Select -> with simple options -> should show the options on mouse click test does not fail.

[JedWatson]

openAfterFocus is intended to control whether the menu opens when the control is focused (which it doesn't by default, this is by design)

However the menu should open when the control is clicked on (regardless of whether it was previously focused or not), this is the regression in the fix you've linked to.

Not sure why the test isn't failing 😞

[jochenberger]

The test succeeds because handleInputFocus is called before handleMouseDown. In the browser (Firefox at least), it's the other way around. That's why, in the test, the menu is opened in https://github.com/JedWatson/react-select/blob/v1.0.0-rc.7/src/Select.js#L257

[jochenberger]

Oh, I get it, the tests focus the select from beforeEach:

...
    at Select.handleInputFocus (/home/jochen/git/upstream/react-select/src/Select.js:320:14)
...
    at Object.focus (/home/jochen/git/upstream/react-select/node_modules/react-dom/lib/ReactTestUtils.js:349:18)
    at findAndFocusInputControl (/home/jochen/git/upstream/react-select/test/Select-test.js:130:24)
    at createControl (/home/jochen/git/upstream/react-select/test/Select-test.js:150:4)
    at Context.<anonymous> (/home/jochen/git/upstream/react-select/test/Select-test.js:261:15)

So there is no test for "no focus -> click -> should show menu". Should we create one or modify the existing test case?

[jochenberger]

See also #1527