Use ReactDOM from window/global scope

[harlow]

Facebook's install page (https://github.com/facebook/react#installation) recommends including both React and ReactDOM from CDN.

<!-- The core React library -->
<script src="https://fb.me/react-0.14.0.js"></script>
<!-- The ReactDOM Library -->
<script src="https://fb.me/react-dom-0.14.0.js"></script>

By using this style we don't need to vendor ReactDOM directly. Would it make sense to do this:

var ReactDOM = (typeof window !== "undefined" ? window['ReactDOM'] : typeof global !== "undefined" ? global['ReactDOM'] : null);

Here:
https://github.com/JedWatson/react-select/blob/master/dist/react-select.js#L73

Thoughts?

[twe4ked]

👍

[wavejumper]

Another 👍 - would allow this library to work for other compile to js languages (eg clojurescript)

[TigerC10]

Count that +1 for 👍 - this killed react-select in my build system since I'm not leveraging browserify or requirejs (yet).

[sobrinho]

Another 👍, the component is broken on browsers without module loaders.

[bavardage]

👍

[l4u]

👍 When react-select is used with Bower and react-rails, it shows Error: Cannot find module 'react-dom'. When we can reuse window.ReactDOM, it works.

[dbkaplun]

+1

[twe4ked]

@JedWatson is there a reason not to do this?

[twe4ked]

Thanks, I'll give this a go now!

[JedWatson]

@twe4ked had to figure out the right way to do it without interfering with the other build processes and target environments. Done now, and I've added an updated usage example in examples/src/standalone.html

[twe4ked]

Actually I'm using bower so I'm not sure this will fix it for me. I'll have a look now.

Edit: Thanks for the explanation :)

[JedWatson]

I'll have to publish a new version before it works from bower, but you can test it by downloading the repo directly from npm and dropping the dist folder into your project (this is effectively what bower does anyway)