Fix async loadOptions bug.#1054
Closed
chenzhihao wants to merge 1 commit intoJedWatson:masterfrom
chenzhihao:master
Closed
Fix async loadOptions bug.#1054chenzhihao wants to merge 1 commit intoJedWatson:masterfrom chenzhihao:master
chenzhihao wants to merge 1 commit intoJedWatson:masterfrom
chenzhihao:master
Conversation
We should not return a promise here. The retured value will be used at handleInputChange() of Select.js. And this value will be used to setState as 'inputValue' which will become '[object Promise]'.
Contributor
|
This should get pulled in ASAP. |
Collaborator
|
This issue has been resolved via PR #1226 by way of an |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not return a promise here.
The code:
is still a promise.
The returned value will be used at handleInputChange() of Select.js();
And this value will be used to 'setState(...)' as 'inputValue' which will finally become '[object Promise]' string as 'inputValue'.