adding a nvmrc file and adding coverage to eslintignore#1137
Merged
gwyneplaine merged 1 commit intoJedWatson:masterfrom Oct 22, 2017
Merged
adding a nvmrc file and adding coverage to eslintignore#1137gwyneplaine merged 1 commit intoJedWatson:masterfrom
gwyneplaine merged 1 commit intoJedWatson:masterfrom
Conversation
Contributor
Author
|
ugh. it looks like there's an issue with tests running in the latest version of react (15.3.0 was just released 4 days ago and now tests are failing on all branches. I just checked using |
Contributor
Author
|
|
- also adding coverage to exclusion in eslintignore
Collaborator
|
thanks for this @uxtx, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've taken to using an nvmrc file in my node projects to peg the node version, and thought it might be helpful here. This allows autoswitching to be much easier, especially when used in conjunction with this plugin https://github.com/creationix/nvm#zsh
I also adding coverage to exclusion in eslintignore - if you happened to run
npm run coverprior tonpm test, you'd get linting errors from the coverage report.