Update aria-only class to have absolute positioning#1243
Merged
gwyneplaine merged 1 commit intoJedWatson:masterfrom Oct 27, 2017
Merged
Update aria-only class to have absolute positioning#1243gwyneplaine merged 1 commit intoJedWatson:masterfrom
gwyneplaine merged 1 commit intoJedWatson:masterfrom
Conversation
When the component is restyled using flex, the width of the aria-only box causes the width of the `Select-multi-value-wrapper` to fluctuate when clicking into the input, and starting to type. Making this `position: absolute` removes it from the flow of flex, and thus solves this issue. This seems to be a standard way to do this, while keeping it accessible. See: http://a11yproject.com/posts/how-to-hide-content/ http://itstiredinhere.com/accessibility/
Collaborator
|
Thanks @JHilker this has been merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the component is restyled using flex, the width of the aria-only box causes the width of the
Select-multi-value-wrapperto fluctuate when clicking into the input, and starting to type. Making thisposition: absoluteremoves it from the flow of flex, and thus solves this issue.This seems to be a standard way to do this, while keeping it accessible. See:
http://a11yproject.com/posts/how-to-hide-content/
http://itstiredinhere.com/accessibility/
Error case:
