Skip to content

Fix for Creatable doesn't allow input key down handling. Issue #1247 #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JedWatson merged 2 commits into from
Sep 25, 2016
Merged

Fix for Creatable doesn't allow input key down handling. Issue #1247 #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
290aa15
Fix for Creatable doesn't allow input key down handling. Issue #1247
Sep 23, 2016
d2ff4a9
Add unit test for fix - Creatable doesn't allow input key down handli…
Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Creatable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ const Creatable = React.createClass({
},

onInputKeyDown (event) {
const { shouldKeyDownEventCreateNewOption } = this.props;
const { shouldKeyDownEventCreateNewOption, onInputKeyDown } = this.props;
const focusedOption = this.select.getFocusedOption();

if (
Expand All @@ -169,6 +169,8 @@ const Creatable = React.createClass({

// Prevent decorated Select from doing anything additional with this keyDown event
event.preventDefault();
} else if (onInputKeyDown) {
onInputKeyDown(event);
}
},

Expand Down
5 changes: 5 additions & 0 deletions test/Creatable-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,4 +232,9 @@ describe('Creatable', () => {
expect(test(188), 'to be', true);
expect(test(1), 'to be', false);
});

it('default :onInputKeyDown should run user provided handler.', (done) => {
createControl({ onInputKeyDown: event => done() });
return creatableInstance.onInputKeyDown({ keyCode: 97 });
});
});