creatable-runs-onInputChange-prop: Fix Creatable to use onInputChange…#1350
Closed
wmcmeans wants to merge 1 commit intoJedWatson:masterfrom
Closed
creatable-runs-onInputChange-prop: Fix Creatable to use onInputChange…#1350wmcmeans wants to merge 1 commit intoJedWatson:masterfrom
wmcmeans wants to merge 1 commit intoJedWatson:masterfrom
Conversation
… function passed as prop
Author
|
Addresses issue #1349 |
4bc189c to
8f40120
Compare
|
Looks like an onInputChange prop works for Creatable in v0.9.1 but not v1.0.0-rc.1. This branch fixes the issue for me. Thanks! Hey @JedWatson is there any way this PR can be merged soon? |
|
👍 can you please accept this PR .. ? |
Merged
|
@JedWatson Is it possible to merge this branch soon? This fixes some blocking issues for us. Thanks :) |
|
I think this change had been already implemented in ver. 1.0.0-rc2 |
|
@takashi Good find! I do see that a (slightly different) fix was added to the base branch after this PR was opened, and that was released with v1.0.0-rc.2 which works for me.
|
Eeki
pushed a commit
to Medisapiens/react-select
that referenced
this pull request
Jan 13, 2017
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… function passed as prop