Skip to content

creatable-runs-onInputChange-prop: Fix Creatable to use onInputChange…#1350

Closed
wmcmeans wants to merge 1 commit intoJedWatson:masterfrom
wmcmeans:creatable-runs-onInputChange-prop
Closed

creatable-runs-onInputChange-prop: Fix Creatable to use onInputChange…#1350
wmcmeans wants to merge 1 commit intoJedWatson:masterfrom
wmcmeans:creatable-runs-onInputChange-prop

Conversation

@wmcmeans
Copy link

@wmcmeans wmcmeans commented Nov 3, 2016

… function passed as prop

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.298% when pulling 8f40120 on wmcmeans:creatable-runs-onInputChange-prop into 9dd1d27 on JedWatson:master.

@wmcmeans
Copy link
Author

wmcmeans commented Nov 3, 2016

Addresses issue #1349

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.298% when pulling 4bc189c on wmcmeans:creatable-runs-onInputChange-prop into 9dd1d27 on JedWatson:master.

@wmcmeans wmcmeans force-pushed the creatable-runs-onInputChange-prop branch from 4bc189c to 8f40120 Compare November 3, 2016 16:05
@theopak
Copy link

theopak commented Nov 15, 2016

Looks like an onInputChange prop works for Creatable in v0.9.1 but not v1.0.0-rc.1. This branch fixes the issue for me. Thanks!

Hey @JedWatson is there any way this PR can be merged soon?

@TkDodo
Copy link

TkDodo commented Nov 16, 2016

👍 can you please accept this PR .. ?

@TkDodo TkDodo mentioned this pull request Nov 16, 2016
@skmvasu
Copy link

skmvasu commented Nov 16, 2016

@JedWatson Is it possible to merge this branch soon? This fixes some blocking issues for us. Thanks :)

@takashi
Copy link

takashi commented Dec 8, 2016

I think this change had been already implemented in ver. 1.0.0-rc2

@theopak
Copy link

theopak commented Dec 8, 2016

@takashi Good find! I do see that a (slightly different) fix was added to the base branch after this PR was opened, and that was released with v1.0.0-rc.2 which works for me.

Eeki pushed a commit to Medisapiens/react-select that referenced this pull request Jan 13, 2017
@JedWatson
Copy link
Owner

I believe this can be closed now because #2057 has been merged, could everyone please confirm that it solves the problem correctly for their use-case? and continue discussion on #2056 if not.

Thanks!

@JedWatson JedWatson closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants