Skip to content

fix onInputChange#1411

Closed
svsool wants to merge 1 commit intoJedWatson:masterfrom
svsool:fix2
Closed

fix onInputChange#1411
svsool wants to merge 1 commit intoJedWatson:masterfrom
svsool:fix2

Conversation

@svsool
Copy link

@svsool svsool commented Dec 5, 2016

fix for #1363, value returned from onInputChange will used as nextState in Select.js see https://github.com/JedWatson/react-select/blob/master/src/Select.js#L450, otherwise value normalisation not working

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.318% when pulling 31b4b90 on svsool:fix2 into ef3a468 on JedWatson:master.

@JedWatson
Copy link
Owner

I believe this can be closed now because #2057 has been merged, could everyone please confirm that it solves the problem correctly for their use-case? and continue discussion on #2056 if not.

Thanks!

@JedWatson JedWatson closed this Oct 18, 2017
@svsool
Copy link
Author

svsool commented Oct 18, 2017

Yes, this problem solved in #2057, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants