Skip to content

Fixed Numeric Values Multi-Select#1600

Closed
edmondpr wants to merge 1 commit intoJedWatson:masterfrom
edmondpr:master
Closed

Fixed Numeric Values Multi-Select#1600
edmondpr wants to merge 1 commit intoJedWatson:masterfrom
edmondpr:master

Conversation

@edmondpr
Copy link

Selected options weren’t being added to the input in Multi-Select mode
for Numeric Values

Selected options weren’t being added to the input in Multi-Select mode
for Numeric Values
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 87.818% when pulling 1b06702 on edmondpr:master into 2249f26 on JedWatson:master.

@agirton
Copy link
Collaborator

agirton commented Jun 27, 2017

Hi @edmondpr since the test coverage went down by a lot, can you add some unit tests to cover this?

@gwyneplaine
Copy link
Collaborator

Hi @edmondpr I'm having trouble reproducing the error case for this PR, would you be able to provide me with steps to reproduce, along with the version of react-select this was occuring in?

@edmondpr
Copy link
Author

edmondpr commented Sep 15, 2017 via email

@gwyneplaine
Copy link
Collaborator

@edmondpr thanks for this, reproduced the error. I've addressed this in a separate PR which accounts for cases where we are interacting with a set of options that have a mixed bag of Strings and Numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants