Fixed Numeric Values Multi-Select#1600
Closed
edmondpr wants to merge 1 commit intoJedWatson:masterfrom
Closed
Conversation
Selected options weren’t being added to the input in Multi-Select mode for Numeric Values
This was referenced Jun 24, 2017
Collaborator
|
Hi @edmondpr since the test coverage went down by a lot, can you add some unit tests to cover this? |
Collaborator
|
Hi @edmondpr I'm having trouble reproducing the error case for this PR, would you be able to provide me with steps to reproduce, along with the version of react-select this was occuring in? |
Author
|
Hi Charles,
It's very easy to reproduce on the demo page of React-Select:
http://jedwatson.github.io/react-select/
Go to the Numeric Values section, make sure Multi-select is checked and try
to add values from the dropdown menu. You'll notice that no value is being
added.
Let me know if you still have issues reproducing.
I've created the fix for the issue here:
1b06702
Cheers,
Edmond
…On Wed, Sep 13, 2017 at 4:42 AM, Charles ***@***.***> wrote:
Hi @edmondpr <https://github.com/edmondpr> I'm having trouble reproducing
the error case for this PR, would you be able to provide me with steps to
reproduce, along with the version of react-select this was occuring in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1600 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGOmEfwDBpdZddE0D4wPMsNf6fOwGdF4ks5shzL_gaJpZM4MaZHr>
.
|
Collaborator
|
@edmondpr thanks for this, reproduced the error. I've addressed this in a separate PR which accounts for cases where we are interacting with a set of options that have a mixed bag of Strings and Numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected options weren’t being added to the input in Multi-Select mode
for Numeric Values