Conversation
|
Thanks @dekelb! Would you mind updating the .scss files as well? then I'm 👍 to merge this. |
|
@JedWatson updated the |
agirton
left a comment
There was a problem hiding this comment.
This looks great! Since there is a new prop can add documentation and unit tests to cover this?
| 'is-pseudo-focused': this.state.isPseudoFocused, | ||
| 'is-searchable': this.props.searchable, | ||
| 'has-value': valueArray.length, | ||
| 'Select-rtl': this.props.rtl, |
There was a problem hiding this comment.
This is a nit but it should probably be Select--rtl since rtl is a modifier. Also it feels like it should belong at the top just below the other modifiers. Can you update?
|
Hi, nice work! EDIT |
|
Hi @sag1v this needs documentation and unit tests before we will merge this in. |
|
@agirton something i can help with? to speed things up... :) |
|
Let's give @dekelb one more week to see if he is able to take it on. If not feel free to jump in to finish. |
|
@dekelb regarding the tests i think you should have at least 1 that checks if the element has a |
…-select into feature/rtl_support
|
Added a test on the rtl prop, and regarding the sample - the prev commit already has the rtl example (on the states and on the multiselect samples. |
|
I hope they will merge it soon, we need it as well :) |
|
Hi Sagiv, |
|
@agirton any news regarding this PR? Thanks! |
Resolved merge conflicts and nit in #1613
|
@dekelb thanks for this PR, its now been merged into master |
|
@gwyneplaine thanks for the merge! |
This PR is for RTL support.
Added examples for both single select and multi-select.
Merging this PR will close #1190, #1608