Skip to content

Always pass valueArray to menuRenderer#1731

Closed
chronick wants to merge 1 commit intoJedWatson:masterfrom
chronick:multi-valuearray
Closed

Always pass valueArray to menuRenderer#1731
chronick wants to merge 1 commit intoJedWatson:masterfrom
chronick:multi-valuearray

Conversation

@chronick
Copy link
Contributor

@chronick chronick commented May 18, 2017

My application's designers wish to display a visual indicator for selected items instead of hiding them from the dropdown list when using a multi selector. Always passing the valueArray to the menu renderer seemed to be the best and least-impact way to do so.

The default behavior of the select box appears to be unaffected by this change, since the actual hiding of options happens in the default filterOptions function.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.874% when pulling 75f4050 on chronick:multi-valuearray into 196c7bb on JedWatson:master.

@MrOrz
Copy link

MrOrz commented Jun 30, 2017

Just encountered this and @chronick 's fork worked like a charm.

Conditionally pass in valueArray does not make sense to me either.

@gwyneplaine
Copy link
Collaborator

@chronick thanks for this, this particular fix has been pulled into master as part of #1850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants