Always pass valueArray to menuRenderer#1731
Closed
chronick wants to merge 1 commit intoJedWatson:masterfrom
Closed
Always pass valueArray to menuRenderer#1731chronick wants to merge 1 commit intoJedWatson:masterfrom
chronick wants to merge 1 commit intoJedWatson:masterfrom
Conversation
|
Just encountered this and @chronick 's fork worked like a charm. Conditionally pass in valueArray does not make sense to me either. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My application's designers wish to display a visual indicator for selected items instead of hiding them from the dropdown list when using a multi selector. Always passing the
valueArrayto the menu renderer seemed to be the best and least-impact way to do so.The default behavior of the select box appears to be unaffected by this change, since the actual hiding of options happens in the default
filterOptionsfunction.