Add inputValue to menuRenderer#1732
Merged
gwyneplaine merged 1 commit intoJedWatson:masterfrom Oct 24, 2017
Merged
Conversation
Collaborator
|
Hi @chronick thank you for your contribution. While this would be helpful and is a very small change, I want to try and get only critical features for the 1.0 release. We can add merge this after release. |
Closed
ghost
approved these changes
Jul 11, 2017
Collaborator
|
@chronick, thanks for this, merging this in now as its value added and has zero impact on default behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wish to override the
optionRendererto highlight each search result with the main inputs' query. This means that the option at some level will need access to the input's value. I originally attempted to append the input value to the data by overridingfilterOptions, but that broke filtering and selection. This seemed to be the most reasonable way to do it, and does not affect default behavior.