Add variable for focused input background#1998
Conversation
a218808 to
ffe5b12
Compare
|
Thanks @aronstrandberg, happy to accept this addition. Would you please add it to the |
JedWatson
left a comment
There was a problem hiding this comment.
Please fix this up and add the .scss files as well, as we can merge this 👍
less/select.less
Outdated
| // control options | ||
| @select-input-bg: #fff; | ||
| @select-input-bg-disabled: #f9f9f9; | ||
| @select-input-bg-focus: #fff; |
There was a problem hiding this comment.
Please make this default to @select-input-bg in case that has been customised, otherwise this would be a breaking change.
|
@JedWatson Pushed some commits to adress these things. I couldn't find the equivalent of |
Adds a variable to make it possible to configure the input's background color when focused
2fdedda to
535bc23
Compare
|
@JedWatson I just rebased this on master to adjust for upstream changes. Do you think this is ready to merge? |
|
Looks great @aronstrandberg, thanks! |
|
Do not release feature with big bug : |
Add a variable to make it possible to configure the input's background color when focused.
I was trying to theme the focused state in a project, but found it bit cumbersome, hence the desire for these changes. I'd be happy to make any requested changes from your side.