autofocus --> autoFocus

[gwyneplaine]

autoFocus prop added, deprecation warning added for use of autofocus prop

[coveralls]

Coverage decreased (-0.1%) to 91.862% when pulling e6dbba6 on update/autofocus-prop into 9af79b7 on master.

[JedWatson]

Please add tests for this change and ensure we maintain coverage

[JedWatson]

Please fix the indentation here

[coveralls]

Coverage decreased (-71.5%) to 20.501% when pulling b0d9f1f on update/autofocus-prop into 49b12b0 on master.

[coveralls]

Coverage decreased (-71.5%) to 20.501% when pulling b0d9f1f on update/autofocus-prop into 49b12b0 on master.

[gwyneplaine]

@JedWatson indentation fixed and tests added

[coveralls]

Coverage increased (+0.2%) to 92.175% when pulling 58aecaa on update/autofocus-prop into 49b12b0 on master.

[jochenberger]

Wouldn't it be better to use a custom function for deprecation warning that returns an Error if the old autofocus property is set?
And I think that examples/src/components/States.js should be updated as well.

[gwyneplaine]

Thanks for the feedback @jochenberger, what's the purpose of returning an Error object in this case?

[coveralls]

Coverage increased (+0.2%) to 92.175% when pulling afd8c17 on update/autofocus-prop into 49b12b0 on master.

[jochenberger]

IMHO, returning an Error is more idiomatic React. Also, it will only warn in development mode and doesn't need the check for console. Also, it will not fail if console is available but console.warn is not. ;-)

[JedWatson]

@gwyneplaine please fix the in-line indentation here, should be using spaces for consistency

[JedWatson]

@jochenberger what makes you say that returning an error is more idiomatic react?

we're explicitly continuing to support the autofocus prop for 1.0.0, just putting a deprecation warning in for dev mode - this is modelled specifically after the way that react deprecates features between versions

[coveralls]

Coverage increased (+0.2%) to 92.175% when pulling 8f1f884 on update/autofocus-prop into 49b12b0 on master.

[JedWatson]

@jochenberger I'm going to merge this as-is for now, I may have misunderstood what you meant with the error so please feel free to open another PR with how you meant for this to be implemented.

I checked up on whether we should check for console.warn but it's available in more browsers than react-select supports and all node versions so I think we're safe to just use it.

[JedWatson]

p.s. thanks @gwyneplaine 😁

[jochenberger]

I'm fine with that. I thought that returning an Error might be more idiomatic since it's the way that custom validators should be implemented (https://github.com/facebook/prop-types). But other modules seem to warn directly too, however they usually seem to use warning.

just putting a deprecation warning in for dev mode

I think that the warning will also appear in production. Maybe that should be changed. warning would take care of that.