Skip to content

Async> cache async response regardless of req order #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JedWatson merged 2 commits into from
Sep 21, 2017
Merged

Async> cache async response regardless of req order #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d0396
Async> cache async response regardless of req order
Sep 18, 2017
79f478e
Clear this._callback on cache hit
Sep 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ export default class Async extends Component {
cache &&
Object.prototype.hasOwnProperty.call(cache, inputValue)
) {
this._callback = null;

this.setState({
options: cache[inputValue]
});
Expand All @@ -96,14 +98,14 @@ export default class Async extends Component {
}

const callback = (error, data) => {
if (callback === this._callback) {
this._callback = null;
const options = data && data.options || [];

const options = data && data.options || [];
if (cache) {
cache[inputValue] = options;
}

if (cache) {
cache[inputValue] = options;
}
if (callback === this._callback) {
this._callback = null;

this.setState({
isLoading: false,
Expand Down
28 changes: 28 additions & 0 deletions test/Async-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,34 @@ describe('Async', () => {
return expect(asyncNode.textContent, 'to contain', 'Loading');
});

// TODO: I'm not sure what the best way to test this is, because this test returns positive even
// before the change. However, manual testing by throttling the network with Chrome devtools shows
// that this fixes the issue.
it.skip('caches the result of all option fetches', () => {
const optionResponse = createOptionsResponse(['foo']);
function loadOptions (input, resolve) {
setTimeout(function() {
resolve(null, optionResponse);
}, 10 - input.length);
// resolve(null, optionResponse);
}
createControl({
loadOptions,
});
const instance = asyncInstance;
typeSearchText('t');
typeSearchText('te');
typeSearchText('tes');

// TODO: How to test this?
setTimeout(function() {
console.log(instance._cache);
expect(instance._cache.t, 'to equal', optionResponse.options);
expect(instance._cache.te, 'to equal', optionResponse.options);
expect(instance._cache.tes, 'to equal', optionResponse.options);
}, 30);
});

describe('with callbacks', () => {
it('should display the loaded options', () => {
function loadOptions (input, resolve) {
Expand Down