Skip to content

do not show clear button if value is an empty string#2074

Merged
JedWatson merged 1 commit intoJedWatson:masterfrom
mariegodon:bug-2073
Oct 19, 2017
Merged

do not show clear button if value is an empty string#2074
JedWatson merged 1 commit intoJedWatson:masterfrom
mariegodon:bug-2073

Conversation

@mariegodon
Copy link

@mariegodon mariegodon commented Oct 19, 2017

The clear button should not display if value is an empty string

Fixes #2073

@mariegodon mariegodon changed the title do not show clear button if value is an empty string #2073 do not show clear button if value is an empty string fix #2073 Oct 19, 2017
@mariegodon mariegodon changed the title do not show clear button if value is an empty string fix #2073 do not show clear button if value is an empty string https://github.com/JedWatson/react-select/issues/2073 Oct 19, 2017
@mariegodon mariegodon changed the title do not show clear button if value is an empty string https://github.com/JedWatson/react-select/issues/2073 do not show clear button if value is an empty string Oct 19, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.801% when pulling a8c7757 on mariegodon:bug-2073 into b6ebce8 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for this @mariegodon

Not sure why the test timed out, but it doesn't seem to be related to this so I'll merge and sort that out separately.

@JedWatson JedWatson merged commit f3a46ce into JedWatson:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants