Skip to content

expose children in AsyncCreatable.js#2084

Merged
JedWatson merged 2 commits intomasterfrom
fix/expose-select-to-async-creatable
Oct 23, 2017
Merged

expose children in AsyncCreatable.js#2084
JedWatson merged 2 commits intomasterfrom
fix/expose-select-to-async-creatable

Conversation

@gwyneplaine
Copy link
Collaborator

This PR ports over the fantastic work that @DanielHeath has done to refactor AsyncCreatable to expose the wrapped Select component as a child (as we do in Async and Creatable respectively).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 92.248% when pulling b7e876d on fix/expose-select-to-async-creatable into a1e1069 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.824% when pulling e5b1c66 on fix/expose-select-to-async-creatable into a1e1069 on master.

@JedWatson
Copy link
Owner

re: coverage, this change removes unnecessary code that was previously covered, so the change is due to having less code overall. feel free to ignore.

@JedWatson JedWatson merged commit b6fd3e7 into master Oct 23, 2017
@JedWatson JedWatson deleted the fix/expose-select-to-async-creatable branch October 23, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants