Skip to content

fix not clearing when given invalid values, from #1756#2100

Merged
JedWatson merged 1 commit intomasterfrom
fix/renderClear
Oct 26, 2017
Merged

fix not clearing when given invalid values, from #1756#2100
JedWatson merged 1 commit intomasterfrom
fix/renderClear

Conversation

@gwyneplaine
Copy link
Collaborator

Cleaning up and adding tests to @ticklemynausea's initial PR #1756

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.89% when pulling 8ebda3a on fix/renderClear into ca09183 on master.

@JedWatson
Copy link
Owner

Thanks

@gwyneplaine it looks like this can be optimised so we don't need to call getValueArray in every render - can you look into a subsequent pr that fixes this?

@JedWatson JedWatson merged commit ad50e62 into master Oct 26, 2017
@JedWatson JedWatson deleted the fix/renderClear branch October 26, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants