removing getInputValue function#2108
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Oct 31, 2017
Merged
Conversation
uxtx
force-pushed
the
unused-input-value
branch
from
6d39062 to
82722fb
Compare
Owner
|
Thanks for this @uxtx, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was doing some cleanup and testing work to try to bump up the coverage and ran across this unused
getInputValuefunction - don't see it called anywhere, react-select seems to compile and tests run perfectly without it - looks like it was part of the initial work forallowCreate(7fe723f) , but it seems unused now.