fixed: async doesn't change value when onInputChange returns a value#2133
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Nov 16, 2017
tehbi4:master
Merged
fixed: async doesn't change value when onInputChange returns a value#2133JedWatson merged 1 commit intoJedWatson:masterfrom tehbi4:master
JedWatson merged 1 commit intoJedWatson:masterfrom
tehbi4:master
Conversation
Contributor
Author
|
Hi @JedWatson! Could you review my fix, please? I really need it in my project. |
Owner
|
Thanks @tehbi4, looks good. I'll get this released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1597, fixes #1941, fixes #2069
Function passed through
onInputChangeprop will be called with initial input value (stripDiacriticswill not be applied in caseignoreAccentsandtoLowerCasewill not be applied in caseignoreCase).