Creatable: when promptTextCreator returns only the label, changes don't fire on first Enter key press#2140
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Nov 19, 2017
Conversation
karaggeorge
changed the title
promptTextCreator returns only the entered text, changes don't fire on first Enter key presspromptTextCreator returns only the label, changes don't fire on first Enter key press
Owner
|
Great, thanks @karaggeorge 👍 props for both the fix and explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves this issue: #2125
Bug can be seen here: https://plnkr.co/edit/lC6lJuAYaTItCSJxTjnD?p=preview
Reason
It was caused because when creating a new choice, there is a check to see if the option is unique (even though there is a check for that to even display the new option creator). This check was checking the value against a list of filtered options. This filter was the passed down filter prop and was basically checking the option against itself with the addition of the prompt text. Therefore, by accident if there was a prompt text it was passing, but when using
(label) => label, it was failing.Solution
It has been fixed to check against the list of options available.