Fixed search for invalid label and/or value#2179
Merged
JedWatson merged 3 commits intoJedWatson:masterfrom Nov 28, 2017
yuri-sakharov:fix/search-for-invalid-label-value
Merged
Fixed search for invalid label and/or value#2179JedWatson merged 3 commits intoJedWatson:masterfrom yuri-sakharov:fix/search-for-invalid-label-value
JedWatson merged 3 commits intoJedWatson:masterfrom
yuri-sakharov:fix/search-for-invalid-label-value
Conversation
yuri-sakharov
changed the title
liorbentov
reviewed
Nov 28, 2017
src/utils/defaultFilterOptions.js
Outdated
| var value = option[props.valueKey]; | ||
| var label = option[props.labelKey]; | ||
| var hasValue = typeof (value) !== 'undefined' && value !== null && value !== ''; | ||
| var hasLabel = typeof (label) !== 'undefined' && label !== null && label !== ''; |
There was a problem hiding this comment.
Maybe extract this logic into a function?
liorbentov
reviewed
Nov 28, 2017
| } | ||
|
|
||
| var valueTest = hasValue ? String(value) : null; | ||
| var labelTest = hasLabel ? String(label) : null; |
There was a problem hiding this comment.
Why not include this in the hasX checks?
Author
There was a problem hiding this comment.
It's because there is situation when only one of label or value is invalid and still need to search in valid field.
Owner
|
Thanks for this @yuri-sakharov! Great PR 👍 |
Author
|
@JedWatson thank you too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a results in dropdown if user search "undefined" word when value and/or label are undefined or if search "null" word when value and/or label are null.