Fix/is option unique crash#2185
Merged
JedWatson merged 3 commits intoJedWatson:masterfrom Dec 13, 2017
Chopinsky:fix/isOptionUnique-crash
Merged
Fix/is option unique crash#2185JedWatson merged 3 commits intoJedWatson:masterfrom Chopinsky:fix/isOptionUnique-crash
JedWatson merged 3 commits intoJedWatson:masterfrom
Chopinsky:fix/isOptionUnique-crash
Conversation
|
@JedWatson Do you have any news about the integration of this Pull Request in the new version of react-select? Thanks for your time @Chopinsky! |
Owner
|
Yep, looks great. Thanks @Chopinsky! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix issue #2184, where for some edge cases, if we try to create a new option while the
optionsproperty is null or undefined, the control will crash because functionisOptionUniquewill callfilteronoptionsbefore checking if it's valid to be performed on.