Don't open drop down menu when clear values

[Chopinsky]

This PR is to address issue #1252, where when "clear" button is clicked upon, the drop down menu will prompt to open. This issue is caused by involuntarily firing the focus event after clearing values, where we will prompt the menu regardless of the context.

To address this issue, we will set a flag in the clearValue function, and then reset the flag after the focus handler finishes.

[coveralls]

Coverage increased (+0.07%) to 93.497% when pulling 63f1d10 on Chopinsky:fix/ClearToOpen into 62cdd5d on JedWatson:master.

[garrettdehnketurpin]

Just curious, on when this branch will be merged?

Regards,
Garrett

[JedWatson]

Opening when the clear button is clicked was originally intended behaviour, but having tested the two this does make more sense. Seems like if the user intention is to clear the field, it doesn't necessarily also convey an intention to open the menu... right?

This also makes the "clear" behaviour consistent with the behaviour of the "remove" icon on values in a multi-select, so I'm happy to merge it.

Would you mind resolving the conflict @Chopinsky? I've taken a look and am not 100% confident how to preserve your fix without digging deeper into it.

[coveralls]

Coverage increased (+0.06%) to 93.813% when pulling fbe0567 on Chopinsky:fix/ClearToOpen into 700b79a on JedWatson:master.

[JedWatson]

Nevermind, I'm about to release a version and want to include this so I've dug in deeper and resolved the conflicts. Thanks for the PR @Chopinsky!

[samuelcolvin]

Any chance of getting a release with this included?