fix dropdown menu position for IE 11#2273
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Jan 13, 2018
jharris4:master
Merged
fix dropdown menu position for IE 11#2273JedWatson merged 1 commit intoJedWatson:masterfrom jharris4:master
JedWatson merged 1 commit intoJedWatson:masterfrom
jharris4:master
Conversation
Owner
|
Thanks @jharris4, I suspect the issue is related to the nesting or it should have shown up earlier, but this fix doesn't seem to have any other side-effects so it looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that when using react-select in IE 11 the dropdown menu was incorrectly showing up to the right of the input/value. This may be related to the fact that I have select component nested inside a flex layout.
Adding the
left: 0style fixed it for me so I figured I'd make a PR in case anyone else hits the same issue.I tried to add a screenshot, but it closes the dropdown as soon as i click to take the screenshot... lol