Fix bug where Select shows the value instead of the label #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens if there is no matching option on initial render. Future updates to the options do not fix this condition.
Owner
|
Thanks @sdemjanenko! |
JedWatson
added a commit
that referenced
this pull request
Jun 24, 2015
…pdate Fix bug where Select shows the value instead of the label
|
Hi, really appreciated this fix as I was also experiencing this bug, but it doesn't look like it's in master anymore? Did some other change overwrite this or something? Not in the current build. @JedWatson this commit 7c6223e might've not included the most recent changes when it was added. |
|
I'm using multi with async and I'm seeing this issue too. It eventually loads with the appropriate label, but it seems undesirable to display the value while it fetches the label data. |
JedWatson
added a commit
that referenced
this pull request
Jul 28, 2015
Owner
|
I just realised what's going in here, I didn't pay close enough attention to the PR 😞 It updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens if there is no matching option on initial render. Future
updates to the options do not fix this condition.