Skip to content

replace event.target to event.currentTarget#3380

Merged
gwyneplaine merged 1 commit intoJedWatson:masterfrom
DragorWW:flow-event-target
Jan 25, 2019
Merged

replace event.target to event.currentTarget#3380
gwyneplaine merged 1 commit intoJedWatson:masterfrom
DragorWW:flow-event-target

Conversation

@DragorWW
Copy link
Contributor

@DragorWW DragorWW commented Jan 24, 2019

fix flow error in Select.js, related to #3350

The reason why you want to use event.currentTarget is that event.target may be the wrong element due to event propagation.
see more in:

flow types from react

declare class SyntheticEvent<+T: EventTarget = EventTarget, +E: Event = Event> {
  bubbles: boolean;
  cancelable: boolean;
  +currentTarget: T;
  defaultPrevented: boolean;
  eventPhase: number;
  isDefaultPrevented(): boolean;
  isPropagationStopped(): boolean;
  isTrusted: boolean;
  nativeEvent: E;
  preventDefault(): void;
  stopPropagation(): void;
  // This should not be `T`. Use `currentTarget` instead. See:
  // https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11508#issuecomment-256045682
  +target: EventTarget;
  timeStamp: number;
  type: string;
  persist(): void;
}

@gwyneplaine
Copy link
Collaborator

lgtm thanks @DragorWW

@gwyneplaine gwyneplaine merged commit 4686ea3 into JedWatson:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants