Use preconstruct#3528
Merged
gwyneplaine merged 2 commits intoJedWatson:v3.0.0from May 3, 2019
emmatown:preconstruct
Merged
Conversation
emmatown
commented
Apr 28, 2019
| ], | ||
| "bundlesize": [ | ||
| { | ||
| "path": "./dist/react-select.js" |
Collaborator
Author
There was a problem hiding this comment.
This doesn't really make sense now since we don't have a UMD build, there's probably a tool to do a bundle size check that bundles dependencies and minifies but I wasn't sure if having a bundle size check is a thing we care about having exactly right now so I just removed it.
5 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things here other than adding preconstruct:
npsbecause after adding preconstruct it was only being used to specify the build command for the sitenetlify.tomlwhich tells Netlify how to build the site, right now it's specified in the Netlify UI but that means that changes to the site's build command or dist folder have to be changed in the UI and therefore all branches have to have the same build config, with this though, different branches can have different build configs since it lives in git.