Conversation
makeAsyncSelect was losing the type information from the default props, so, eg, cacheOptions would appear as a required props
Contributor
|
@jdelStrother I did almost the same here #3538 😄 |
Contributor
Author
|
@JedWatson anything that me/mufasa71 can do to help get either of these merged? I'll fix my merge conflicts if you're intending to merge this. |
🦋 Changeset is good to goLatest commit: 87de86e We got this. Not sure what this means? Click here to learn what changesets are. |
Closed
This was referenced Oct 2, 2019
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into flow difficulties using Async & AsyncCreatable - their HOC functions were losing the defaultProps of the components, so, eg:
would complain with the following:
WDYT to this?
I've also changed a couple of string types to React$Node - the children of SingleValue, and the return value from noOptionsMessage. There shouldn't be any functional code changes, just type changes.