fix: Remove unused classnames dependency#3630
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Oct 2, 2019
Merged
Conversation
eps1lon
changed the title
eps1lon
force-pushed
the
fix/remove-classnames
branch
from
7c8ddc5 to
790f3d7
Compare
eps1lon
force-pushed
the
fix/remove-classnames
branch
from
790f3d7 to
d368e2f
Compare
1 task
Contributor
|
Friendly ping @JedWatson |
Owner
|
Oops 😊 you're 100% correct, this should have been removed with v2! thanks for the PR @eps1lon |
JedWatson
added a commit
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classnamesisn't used (anymore?) but still listed as a dependency. This might be confusing to people usingclsxand thinking they pull in (basically) duplicate dependencies.