Replace raf package with requestAnimationFrame#3644
Merged
emmatown merged 3 commits intoJedWatson:masterfrom Oct 2, 2019
Merged
Replace raf package with requestAnimationFrame#3644emmatown merged 3 commits intoJedWatson:masterfrom
emmatown merged 3 commits intoJedWatson:masterfrom
Conversation
Not polyfilled requestAnimationFrame already used here https://github.com/JedWatson/react-select/blob/master/packages/react-select/src/animated/transitions.js#L88 `animatedScrollTo` is never called in node so polyfilling for node does not make sense too. This removed two commonjs packages from user bundlers: raf and performance-now.
Contributor
Author
|
Friendly ping @gwyneplaine |
Contributor
Author
|
Hi @mitchellhamilton. Could you take a look at this PR? |
Contributor
Author
|
Friendly ping @JedWatson |
Contributor
Author
|
@JedWatson @gwyneplaine could you take a look at this please? |
Contributor
Author
|
Friendly ping guys @JedWatson @gwyneplaine @mitchellhamilton |
Contributor
Author
|
Ping @gwyneplaine |
🦋 Changeset is good to goLatest commit: ae66f63 We got this. Not sure what this means? Click here to learn what changesets are. |
emmatown
approved these changes
Oct 2, 2019
Collaborator
emmatown
left a comment
emmatown
left a comment
There was a problem hiding this comment.
Sorry for the wait, Thanks for this!!
This was referenced Oct 2, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not polyfilled requestAnimationFrame already used here
https://github.com/JedWatson/react-select/blob/master/packages/react-select/src/animated/transitions.js#L88
animatedScrollTois never called in node so polyfilling for node doesnot make sense too.
This removed two commonjs packages from user bundlers: raf and
performance-now.