Merged
Conversation
Owner
|
We've already got some heavy dev dependencies for the build process, this doesn't look like it would add much more so I'm happy to put it in there. Worth wearing that badge with pride :) 👍 let me know when it's ready to merge. |
Travis does an npm install automatically, so removed this and replaced it with a npm run coveralls, which runs the tests and submits the coverage to coveralls. This commit still references bruderstein/react-select, this needs to be changed before merging
bruderstein
force-pushed
the
add-coveralls-badge
branch
from
7ca9e73 to
97faa97
Compare
Collaborator
Author
|
Good to go 👍 |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a coverage badge to the readme, integrating coveralls.io.
The badge links and API key need changing if this gets the thumbs up, which I think I can do. You can see the result at bruderstein/react-select
I've been testing it out with my repo and keys, hence the need to update the keys & links, but I didn't want to sign up to coveralls without the 👍
The downside is it adds a
devDependency(coveralls) that is only really needed for travis.