Fix a bug when replacing the input component to be a textarea#3682
Merged
JedWatson merged 9 commits intoJedWatson:masterfrom Oct 2, 2019
Merged
Fix a bug when replacing the input component to be a textarea#3682JedWatson merged 9 commits intoJedWatson:masterfrom
JedWatson merged 9 commits intoJedWatson:masterfrom
Conversation
🦋 Changeset is good to goLatest commit: c7e9c69 We got this. Not sure what this means? Click here to learn what changesets are. |
Owner
|
Thanks @lmvco |
This was referenced Oct 2, 2019
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using react-select, we can provide a custom input component here. If this custom component is a TEXTAREA, some events will not work properly since react-select is expecting the input component to be an INPUT.
This pull request fixes this behavior.