Don't return null if the last item is manually removed

[Mecit]

Fixes the Invalid attempt to spread non-iterable instance which occurs when items are removed from the input one by one.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 21ede43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21ede43:

Sandbox	Source
react-codesandboxer-example	Configuration

[bladey]

Thanks @Mecit!

[ebonow]

Great work. Perhaps you can add one small fix as well while this is open.

Can you add the following after line 34: (or something equivalent)

if (value.find(val => val && val.value === inputValue)) return;

There is another bug present in this example if you try to add a duplicate word.

[Methuselah96]

Thanks for the PR! It makes sense to merge this, but hopefully we can also fix the underlying issue in the code soon too (see #3632 and #4339).

[Methuselah96]

@Mecit Seems like ESLint is failing. Perhaps it doesn't like the ??? Maybe an ESLint upgrade would fix it.

[Mecit]

@Methuselah96 Yes, it seems ESLint 7.2.0 is needed for the nullish coalescing feature. If upgrading the package would be too bothersome, we can consider using || instead. { value: value || [] } would yield the same result.

[Methuselah96]

@Mecit It's probably easier to go with || for now thanks! I'll work on getting ESLint upgraded in a separate PR (it looks like there are a few errors that need to be resolved after upgrading).

[Methuselah96]

@Mecit This should actually be no longer necessary with the merge and release of #4339. Apologies for the back-and-forth on this and it no longer being necessary in the end. We really appreciate the contribution!

[Mecit]

@Methuselah96 no problem. I'm aware my commit was a quick fix to the problem and I'm glad the underlying issue was resolved in a more convenient way.