Refactor ScrollCaptor and ScrollLock into hooks

[Methuselah96]

This is a follow-up PR to #4330, and should not be merged until that one gets merged (since it includes the changes from #4330). This PR is not necessary in order to remove findDOMNode, so it should not block a 4.0 publish.

This PR removes the need force a re-render in ScrollManager since all of the logic is run as an effect.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4bcfb1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4bcfb1b:

Sandbox	Source
react-codesandboxer-example	Configuration

[ebonow]

Looks good. I like the changes though I would like to clear up some of the line spacing to make it more consistent, but that is minor compared to how much better this is to have the functionality better composed into hooks for separation of concerns without having to wrap in 2 HOC components

[ebonow]

@Methuselah96 I was responding to a user about some of the menuPortal styling and props.
#2909 (comment)

I wanted to get your feedback based on what the documentation states and the fact that you happen to be working on this portion of code at the moment. Is the thought process reasonable and do you think it's something you would want to incorporate into this PR or another or not at all?

[Methuselah96]

@ebonow Thanks, I'll take a look when I get a chance.