fix: updates Select types#4465
fix: updates Select types#4465bozdoz wants to merge 2 commits intoJedWatson:masterfrom bozdoz:fix-select-types
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4929f0:
|
|
Hey @bozdoz Jed is a big fan of this PR. The biggest issue at the moment though is that the TypeScript rewrite is nearing completion soon and want to avoid and potential merge conflicts since it's almost complete at this point. We may still follow up with a quality of life release for v4 for those who want to continue Flow development, but thought to at least thank you for this and that it was well received. Same in regards to your findings about aria input values being announced. We have a bit of a pause on larger initiatives until we have the TypeScript version released or at least in alpha. |
|
Thanks for the work on this, we've recently converted the code over to TypeScript (#4489) in preparation for v5 so the Flow types will no longer be relevant. The |
Adds CommonProps to fix an outstanding TODO related to Select['commonProps'] being typed as
any. Updates other related types to adjust for this change.