Consolidate dependencies and remove duplicates

[jgeurts]

Hi! Hope this PR finds you well. I'm not sure how useful this is since it seems that preconstruct does similar at build time.

• Move most dependencies to be devDependencies
• Reduce duplication of dependencies

I ran through all of the scripts in package.json and things appear to work as they did prior to this PR.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2060f64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2060f64:

Sandbox	Source
react-codesandboxer-example	Configuration

[Methuselah96]

Thanks for the PR! Can you keep all the dependencies for the root package and docs package in dependencies instead of splitting it into devDependencies and dependencies? For those packages, it doesn't really matter whether it's a dependency or dev dependency since it will not ever get installed by another package.

[jgeurts]

I'm curious how come you prefer to put everything in dependencies and not lean on devDependencies?

[Methuselah96]

@jgeurts It's purely a stylistic choice (imo) that Jed said he preferred in our maintainers meeting when we looked at this PR. Since those packages are never used outside of this repository there is no functional difference between them being dependencies or devDependencies so might as well just stick them all in dependencies.

(Personally I prefer the semantic difference between dependencies and devDependencies even for apps where it doesn't make a functional difference since it still designates which dependencies are packaged by Webpack and used at runtime, but to each his own and it's Jed's project.)

[Methuselah96]

Or I guess another way of thinking about it is that the docs and root packages are primarily Node packages and the "dev dependencies" are in fact a runtime dependency since the main function of those packages is to start a Webpack build.

[jgeurts]

@jgeurts It's purely a stylistic choice (imo) that Jed said he preferred in our maintainers meeting when we looked at this PR. Since those packages are never used outside of this repository there is no functional difference between them being dependencies or devDependencies so might as well just stick them all in dependencies.

Cool, thanks for the insight!

Resolved

[dcousens]

This is always going to be an arbitrary balance, but I think this is helpful enough as is that we can refine anything else in future pull requests.