Fix view height used for menu positioning#5177
Merged
Methuselah96 merged 4 commits intomasterfrom May 7, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: f88268b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f88268b:
|
|
@Rall3n Could you review/merge this PR? |
Rall3n
approved these changes
May 6, 2022
This was referenced May 7, 2022
Merged
oschwede
added a commit
to Valuedesk/react-select
that referenced
this pull request
Nov 30, 2022
oschwede
added a commit
to Valuedesk/react-select
that referenced
this pull request
Nov 30, 2022
lennartfranke
pushed a commit
to Valuedesk/react-select
that referenced
this pull request
May 19, 2025
Conflicts: packages/react-select/src/components/Menu.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the need for #5167. Extracted from #4913 as a fix that by itself is correct.