Convert LESS to SCSS and re-organise#544
Merged
JedWatson merged 1 commit intoJedWatson:masterfrom Oct 29, 2015
bassjacob:add-sass
Merged
Convert LESS to SCSS and re-organise#544JedWatson merged 1 commit intoJedWatson:masterfrom bassjacob:add-sass
JedWatson merged 1 commit intoJedWatson:masterfrom
bassjacob:add-sass
Conversation
Convert LESS to SCSS using the less2sass gem. Fix references to some mixins in the individual scss files, and allow the importing of the variables separately from the components so an end user can override the variables before use.
Collaborator
Author
|
Hi :) I'm not sure how/if you'd like to handle compiling the scss -> css since it seems like the LESS files are still your active stylesheet. This is probably really specific to my use case, but I needed to use this in an existing SASS ecosystem. Use case is that I can now import the variables and over-ride them in my own sass file before importing the component styles. I'm currently testing this locally, but it seems to be a 1-1 conversion. Is this an addition you're happy with? |
Owner
|
Thanks - I'm not sure how we'll approach maintaining both versions, but at the moment I'm glad to have this more friendly for SASS users! |
JedWatson
added a commit
that referenced
this pull request
Oct 29, 2015
Convert LESS to SCSS and re-organise
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert LESS to SCSS using the less2sass gem. Fix references to some
mixins in the individual scss files, and allow the importing of the
variables separately from the components so an end user can override the
variables before use.