Merged
Conversation
🦋 Changeset detectedLatest commit: 603bd7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 603bd7a:
|
joshuahhh
added a commit
to engraftdev/engraft
that referenced
this pull request
May 2, 2023
…oduleResolution: bundler`
JedWatson
approved these changes
May 3, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5595
closes #4859
The
exportsfield added in #5559 was wrong in a few ways, arethetypeswrong explains this well:This PR makes react-select use Preconstruct's exports field feature which does things correctly, I've also checked the build output on this branch with arethetypeswrong and it reports no errors. Of note is that there is still no bundle for Node ESM, the
.mjsfile used when theimportcondition matches just re-exports from the CJS bundle but fixes the default export (this is new to Preconstruct and is what"importConditionDefaultExport": "default"is doing), the lack of a Node ESM bundle is intentional so the dual package hazard can't happen. Bundlers will use themodulecondition to still have ESM there. There is also intentionally notypescondition, that's unnecessary because Typescript will resolve to theimportordefaultconditions and use the.d.mtsand.d.tsfiles next to the implementations.