Change input back to div #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially reverts the change made here JedWatson#595 By applying a tabIndex on a div element allows it to be focused. This was the reason the div was changed to an input, by putting it back to a div mobile devices display consistent behaviour when the select box recieves focus. IOS would display a chrome at the bottom of the page where as chrome wouldn't.
Owner
|
Thanks @azaharakis, that's much cleaner. |
JedWatson
added a commit
that referenced
this pull request
Nov 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reverts the change made here
#595 By applying a tabIndex on a
div element allows it to be focused. This was the reason the div was changed to
an input, by putting it back to a div mobile devices display consistent behaviour
when the select box recieves focus. IOS would display a chrome at the bottom
of the page where as chrome wouldn't.